Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS / iOS] Switch Vulkan init to VK_EXT_metal_surface extension. #87999

Merged
merged 1 commit into from
Feb 13, 2024
Merged

[macOS / iOS] Switch Vulkan init to VK_EXT_metal_surface extension. #87999

merged 1 commit into from
Feb 13, 2024
+18 −18

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Feb 5, 2024

Fixes #87866

@bruvzg bruvzg added this to the 4.3 milestone Feb 5, 2024
@bruvzg bruvzg marked this pull request as ready for review February 6, 2024 18:57
@bruvzg bruvzg requested review from a team as code owners February 6, 2024 18:57
@akien-mga akien-mga changed the title [macOS / iOS] Switch Vulkan init to VK_EXT_metal_surface extension. [macOS / iOS] Switch Vulkan init to VK_EXT_metal_surface extension. Feb 13, 2024
akien-mga
akien-mga approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase, otherwise the changes make sense to me.

@akien-mga akien-mga merged commit b50001e into godotengine:master Feb 13, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg mentioned this pull request Feb 20, 2024
Merged
@Nordup
Copy link

Nordup commented Jul 4, 2024

Any plans backporting this to 4.2?
Seems pretty easy) something like this

@akien-mga akien-mga added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release enhancement platform:ios platform:macos topic:porting
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Dev_build editor spams deprecation warnings on newer Vulkan SDK
3 participants
@bruvzg @akien-mga @Nordup